Simplify lhs before passing to symex_assign #2230
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Error from the test-gen testsuite: "byte-wise updates of pointers are unsupported" (from flattening/bv_pointer.cpp) |
smowton
approved these changes
May 23, 2018
|
@smowton Thanks a lot! Is there any way you could create a test for me that I can look at? What I'll need to look at is the output of --program-only on that test before and after the patch. It looks like there are more byte updates rather than fewer, which is unexpected. (In another PR I have support for byte-updates of pointers, but that's a while away.) |
|
Test-gen doesn't have --program-only, but here are the VCC dumps which also show the problem. program-with.txt is with your patch, program-without.txt is current cbmc develop. |
This can help avoid some uses of byte_update, as the regression test shows.
tautschnig
force-pushed
the
simplify-lhs-new
branch
from
6a1df49 to
09e3f82
Compare
|
The test and extra safety net are being merged into the branch used in #3725, closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can help avoid some uses of byte_update, as the regression test shows.
This is the same as #34, created as a new PR to hopefully make Travis happy again.